Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room screen header #86

Merged
merged 11 commits into from
Jun 21, 2022
Merged

Room screen header #86

merged 11 commits into from
Jun 21, 2022

Conversation

ismailgulek
Copy link
Contributor

@ismailgulek ismailgulek commented Jun 21, 2022

Fixes #35

Plain Encrypted
Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-21 at 16 04 33 Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-21 at 16 05 19

@ismailgulek ismailgulek requested a review from pixlwave June 21, 2022 12:58
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2022

Codecov Report

Merging #86 (648debd) into develop (4738f30) will increase coverage by 5.80%.
The diff coverage is 64.76%.

❗ Current head 648debd differs from pull request most recent head 52bbe3e. Consider uploading reports for the commit 52bbe3e to get more accurate results

@@             Coverage Diff             @@
##           develop      #86      +/-   ##
===========================================
+ Coverage    18.36%   24.17%   +5.80%     
===========================================
  Files          131      134       +3     
  Lines         9638     9788     +150     
  Branches      4829     4886      +57     
===========================================
+ Hits          1770     2366     +596     
+ Misses        7810     7352     -458     
- Partials        58       70      +12     
Impacted Files Coverage Δ
ElementX/Sources/AppCoordinator.swift 0.00% <0.00%> (ø)
ElementX/Sources/AppCoordinatorStateMachine.swift 0.00% <0.00%> (ø)
ElementX/Sources/Generated/Assets.swift 51.28% <ø> (ø)
...tX/Sources/Other/ElementNavigationController.swift 0.00% <0.00%> (ø)
.../Sources/Other/Routers/NavigationRouterStore.swift 0.00% <0.00%> (ø)
...urces/Screens/BugReport/BugReportCoordinator.swift 45.23% <0.00%> (+4.81%) ⬆️
...Sources/Screens/BugReport/BugReportViewModel.swift 34.88% <ø> (-0.68%) ⬇️
...ces/Screens/HomeScreen/HomeScreenCoordinator.swift 0.00% <ø> (ø)
.../Sources/Screens/HomeScreen/HomeScreenModels.swift 7.14% <ø> (ø)
...urces/Screens/HomeScreen/HomeScreenViewModel.swift 15.15% <ø> (-1.69%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 591f835...52bbe3e. Read the comment docs.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The room screen is starting looking like Element now 😎

ElementX/Sources/UITestsAppCoordinator.swift Show resolved Hide resolved
changelog.d/35.change Outdated Show resolved Hide resolved
UITests/Sources/RoomScreenUITests.swift Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ismailgulek ismailgulek merged commit 7dcd494 into develop Jun 21, 2022
@ismailgulek ismailgulek deleted the ismail/35_room_screen_header branch June 21, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Room screen: Header UI
3 participants