-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flescio/create room action #925
Conversation
Generated by 🚫 Danger Swift against f662e21 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #925 +/- ##
===========================================
- Coverage 49.14% 48.98% -0.17%
===========================================
Files 330 330
Lines 20025 20120 +95
Branches 11054 11100 +46
===========================================
+ Hits 9842 9856 +14
- Misses 9906 9985 +79
- Partials 277 279 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but I left some comments inline 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀it!
9a403c4
to
f662e21
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Fix a UI bug in the invites screen
Resolve #630
Add the creation action of a room.
Add the task runner with timeout.
After a room is created it's not available right away, so it waits for the room id and room name to be present in the room summary list.