Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plain timeline styler #94

Merged
merged 14 commits into from
Jun 27, 2022
Merged

Plain timeline styler #94

merged 14 commits into from
Jun 27, 2022

Conversation

ismailgulek
Copy link
Contributor

@ismailgulek ismailgulek commented Jun 24, 2022

Fixes #92

Plain Bubbles Settings
Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-24 at 15 27 39 Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-24 at 15 27 56 Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-24 at 16 14 40

@ismailgulek ismailgulek requested a review from pixlwave June 24, 2022 12:29
@github-actions
Copy link

github-actions bot commented Jun 24, 2022

Changes in 94 (2022-06-27)

✨ Features

  • Implement rageshake service. (#23)
  • Add filtering for rooms by name. (#26)
  • Settings screen minimal implementation. (#37)
  • DesignKit: Add initial implementation of DesignKit to the repo as a Swift package. (#43)
  • Room timeline: Add plain styler and add timeline option in settings screen. (#92)

🙌 Improvements

  • Room: Use bubbles in the timeline. (#34)
  • Room: Add header view containing room avatar and encryption badge. (#35)
  • Add a UserSessionStore and the splash screen from Element iOS. (#40)
  • DesignKit: Add DesignKit to the ElementX project, style the login screen with it and tint the whole app. (#43)
  • Settings: Auto dismiss bug report screen and show a success indicator when bug report completed. (#76)
  • Bug report: Add GH labels. (#77)
  • Danger: Add a check for png files and warn to use SVG and PDF files. (#87)

🐛 Bugfixes

  • ElementInfoPlist: Use custom template for Info.plist. (#71)

🧱 Build

  • Use v0.0.1 of the DesignTokens package. (#78)
  • Update to v0.0.2 of the DesignTokens package. (#90)

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/YftStX

@github-actions
Copy link

github-actions bot commented Jun 24, 2022

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against 11a3d0b

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that didn't go away for long 😅 Comments inline.

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2022

Codecov Report

Merging #94 (30ce941) into develop (b6b8b4b) will increase coverage by 0.46%.
The diff coverage is 44.14%.

❗ Current head 30ce941 differs from pull request most recent head 11a3d0b. Consider uploading reports for the commit 11a3d0b to get more accurate results

@@             Coverage Diff             @@
##           develop      #94      +/-   ##
===========================================
+ Coverage    24.52%   24.99%   +0.46%     
===========================================
  Files          137      141       +4     
  Lines        10029    10040      +11     
  Branches      4946     4964      +18     
===========================================
+ Hits          2460     2509      +49     
+ Misses        7493     7454      -39     
- Partials        76       77       +1     
Impacted Files Coverage Δ
...mentX/Sources/Generated/Strings+Untranslated.swift 100.00% <ø> (ø)
...creen/View/Style/TimelineItemPlainStylerView.swift 0.00% <0.00%> (ø)
...omScreen/View/Timeline/EmoteRoomTimelineView.swift 0.00% <0.00%> (ø)
...omScreen/View/Timeline/ImageRoomTimelineView.swift 0.00% <0.00%> (ø)
...mScreen/View/Timeline/NoticeRoomTimelineView.swift 0.00% <0.00%> (ø)
...oomScreen/View/Timeline/TextRoomTimelineView.swift 18.51% <6.25%> (-10.06%) ⬇️
...ces/Screens/RoomScreen/View/TimelineItemList.swift 67.17% <66.66%> (-0.27%) ⬇️
...ens/RoomScreen/View/TimelineSenderAvatarView.swift 70.00% <70.00%> (ø)
...een/View/Style/TimelineItemBubbledStylerView.swift 64.04% <76.19%> (ø)
...Screens/RoomScreen/View/Style/TimelineStyler.swift 77.77% <77.77%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6b8b4b...11a3d0b. Read the comment docs.

@ismailgulek ismailgulek requested a review from pixlwave June 27, 2022 07:17
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good to me 😎

I would like to think/discuss about the architecture of settings storage a bit more, but that isn't necessary for this PR :)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ismailgulek ismailgulek merged commit 36c3450 into develop Jun 27, 2022
@ismailgulek ismailgulek deleted the ismail/92_plain_timeline branch June 27, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plain Timeline View
3 participants