-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plain timeline styler #94
Conversation
Changes in 94 (2022-06-27)✨ Features
🙌 Improvements
🐛 Bugfixes
🧱 Build 📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/YftStX |
Generated by 🚫 Danger Swift against 11a3d0b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well that didn't go away for long 😅 Comments inline.
ElementX/Sources/Screens/RoomScreen/View/Style/TimelineItemBubbledStylerView.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/Style/TimelineItemPlainStylerView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/Style/TimelineStyler.swift
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #94 +/- ##
===========================================
+ Coverage 24.52% 24.99% +0.46%
===========================================
Files 137 141 +4
Lines 10029 10040 +11
Branches 4946 4964 +18
===========================================
+ Hits 2460 2509 +49
+ Misses 7493 7454 -39
- Partials 76 77 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, looks good to me 😎
I would like to think/discuss about the architecture of settings storage a bit more, but that isn't necessary for this PR :)
ElementX/Sources/Screens/RoomScreen/View/Style/TimelineStyle.swift
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Fixes #92