Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towncrier fixes #97

Merged
merged 5 commits into from
Jun 27, 2022
Merged

Towncrier fixes #97

merged 5 commits into from
Jun 27, 2022

Conversation

ismailgulek
Copy link
Contributor

Fixes #96

@github-actions
Copy link

github-actions bot commented Jun 27, 2022

Changes in 97 (2022-06-27)

✨ Features

  • Implement rageshake service. (#23)
  • Add filtering for rooms by name. (#26)
  • Settings screen minimal implementation. (#37)
  • DesignKit: Add initial implementation of DesignKit to the repo as a Swift package. (#43)
  • Room timeline: Add plain styler and add timeline option in settings screen. (#92)

🙌 Improvements

  • Room: Use bubbles in the timeline. (#34)
  • Room: Add header view containing room avatar and encryption badge. (#35)
  • Add a UserSessionStore and the splash screen from Element iOS. (#40)
  • DesignKit: Add DesignKit to the ElementX project, style the login screen with it and tint the whole app. (#43)
  • Settings: Auto dismiss bug report screen and show a success indicator when bug report completed. (#76)
  • Bug report: Add GH labels. (#77)
  • Danger: Add a check for png files and warn to use SVG and PDF files. (#87)

🐛 Bugfixes

  • ElementInfoPlist: Use custom template for Info.plist. (#71)

🧱 Build

  • Use v0.0.1 of the DesignTokens package. (#78)
  • Update to v0.0.2 of the DesignTokens package. (#90)
  • Fix Danger's changelog detection. (#74)

Others

  • Fix project urls in Towncrier configuration. (#96)

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/7LgZCN

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022

Codecov Report

Merging #97 (104273f) into develop (36c3450) will not change coverage.
The diff coverage is n/a.

❗ Current head 104273f differs from pull request most recent head 2fdb2db. Consider uploading reports for the commit 2fdb2db to get more accurate results

@@           Coverage Diff            @@
##           develop      #97   +/-   ##
========================================
  Coverage    24.99%   24.99%           
========================================
  Files          141      141           
  Lines        10040    10040           
  Branches      4964     4964           
========================================
  Hits          2509     2509           
  Misses        7454     7454           
  Partials        77       77           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36c3450...2fdb2db. Read the comment docs.

@ismailgulek ismailgulek marked this pull request as ready for review June 27, 2022 13:23
@ismailgulek ismailgulek requested review from a team and pixlwave and removed request for a team June 27, 2022 13:23
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ismailgulek ismailgulek merged commit cc14f1f into develop Jun 27, 2022
@ismailgulek ismailgulek deleted the ismail/96_towncrier_fixes branch June 27, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Towncrier Configuration Errors
3 participants