Skip to content

Commit

Permalink
remove exports field to try and prevent vite bug resolving asset url
Browse files Browse the repository at this point in the history
downside is that we can't export cjs version anymore
  • Loading branch information
bwindels committed Jan 12, 2022
1 parent a5eb386 commit d7290bf
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 11 deletions.
11 changes: 2 additions & 9 deletions scripts/sdk/base-manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,7 @@
"name": "hydrogen-view-sdk",
"description": "Embeddable matrix client library, including view components",
"version": "0.0.2",
"main": "./hydrogen.cjs.js",
"exports": {
".": {
"import": "./hydrogen.es.js",
"require": "./hydrogen.cjs.js"
},
"./paths/vite": "./paths/vite.js",
"./style.css": "./style.css"
},
"types": "types/lib.d.ts"
"main": "./hydrogen.es.js",
"type": "module"
}
19 changes: 17 additions & 2 deletions scripts/sdk/create-manifest.js
100755 → 100644
Original file line number Diff line number Diff line change
@@ -1,7 +1,22 @@
#!/usr/bin/env node
const fs = require("fs");
const appManifest = require("../../package.json")
const baseSDKManifest = require("./base-manifest.json")
const appManifest = require("../../package.json");
const baseSDKManifest = require("./base-manifest.json");
/*
need to leave exports out of base-manifest.json because of #vite-bug,
with the downside that we can't support environments that support
both esm and commonjs modules, so we pick just esm.
```
"exports": {
".": {
"import": "./hydrogen.es.js",
"require": "./hydrogen.cjs.js"
},
"./paths/vite": "./paths/vite.js",
"./style.css": "./style.css"
},
```
*/
const mergeOptions = require('merge-options');

const manifestExtension = {
Expand Down

0 comments on commit d7290bf

Please sign in to comment.