Only initialize Crypto when olm is provided
#691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hrowing and stopping all JavaScript Relevant error if you crypto is used in a non-secure context like a local LAN IP `http://192.168.1.151:3050/` ``` Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'deriveBits') at new Crypto at new Platform at mountHydrogen ``` For my use-case with https://github.com/matrix-org/matrix-public-archive, I don't need crypto/encryption at all. Docs: - https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts - https://developer.mozilla.org/en-US/docs/Web/API/Crypto/subtle - "Secure context: This feature is available only in secure contexts (HTTPS), in some or all supporting browsers." --- Related to #579
|
If you don't pass in the olm paths to the platform class, isn't encryption disabled? That's the idea, but this is very untested ... |
bwindels
suggested changes
Mar 1, 2022
MadLittleMods
changed the title
window.crypto.subtle in secure contexts to avoid it throwing and stopping all JavaScript.Crypto when olm is provided
bwindels
approved these changes
Mar 3, 2022
|
Thanks for the review and merge @bwindels 🐻 Good shout on the alternative way to disable 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only initialize
Cryptowhen olm is provided.Split out from #653
As a note,
window.crypto.subtleis only avaialble in secure contexts(window.isSecureContext). Relevant error if you crypto is used in a non-secure context like a local LAN IPhttp://192.168.1.151:3050/For my use-case with https://github.com/matrix-org/matrix-public-archive, I don't need crypto/encryption at all so if there was a way to completely disable, that would be even better. Related to #579
Docs: