Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Firefox account SSO doesn’t work #3337

Closed
ara4n opened this issue Oct 1, 2019 · 6 comments · Fixed by #3419
Closed

Firefox account SSO doesn’t work #3337

ara4n opened this issue Oct 1, 2019 · 6 comments · Fixed by #3419
Assignees
Labels
mozilla Mozilla feedback

Comments

@ara4n
Copy link
Member

ara4n commented Oct 1, 2019

Apparently signing in with FxA on Riot and RiotX still fails with:
"Cookies and local storage are required"

@532910
Copy link
Contributor

532910 commented Oct 12, 2019

I don't see such option at all.

@justdave
Copy link

I don't see such option at all.

If you pick "Single-sign on" (sic) as the login method, Firefox Account is one of the options given on the Auth0 screen that it takes you to (if you weren't already logged into Auth0).

It still fails with the above-mentioned cookie error if I try it though.

@justdave
Copy link

This is specifically with mozilla.modular.im as the server, fwiw

@laghee
Copy link

laghee commented Jan 28, 2020

If I'm understanding this correctly, this looks to be solvable either by using the user's default browser rather than a webview here (which would be preferred per OAuth RFC):
https://github.com/vector-im/riot-android/blob/f3b8c4c6c89a6660611acaa127d96af1e1261d72/vector/src/main/java/im/vector/activity/VectorWebViewActivity.kt#L35

Or we can go for more of a hack by finding a way to support OAuth without local storage on the mozilla/fxa side, where there's an (old-ish) existing issue.

While there are workarounds (e.g., using GitHub with 2FA), this is a fairly annoying problem for those of us who use their FF account to auth in. Since I logged onto the new matrix modular server with Firefox auth originally, I can't have the same user name on android using GitHub auth (which also seems to mean I can't access any of the same private rooms I'm in on the desktop/web app).

Someone at a higher pay grade might know who would be the appropriate person to ping to prioritize here?

@mwt
Copy link

mwt commented Feb 4, 2020

Can we add an option (or default behavior) to allow the use of the default browser instead of the webview as mentioned above. It seems like the simplest solution, and will help other companies down the line who want to use SSO.

At a minimum, it would be nice if the application fell back to the browser if Android WebView is disabled. Currently, the application just crashes.

@jryans jryans added the mozilla Mozilla feedback label Feb 4, 2020
@bmarty bmarty self-assigned this Feb 5, 2020
bmarty added a commit that referenced this issue Feb 6, 2020
@bmarty
Copy link
Member

bmarty commented Feb 10, 2020

Fix in release 0.9.10

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
mozilla Mozilla feedback
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants