This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Tidy codebase #1784
Merged
Tidy codebase #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit acfe308)
…nto tidy-codebase
|
@kaiyou: thank for your contribution. Could you please sign off your PR (see https://github.com/vector-im/riot-android/blob/master/CONTRIBUTING.rst#sign-off)? If you agree, all that's needed is to include the line in your commit or pull request comment: |
|
Yes of course. Does this still merge without conflict though? |
|
There is no conflict for the moment ;) |
|
Just added the sign-off to the PR, thanks for reviewing this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the application UI, I basically read through large sections of the codebase and try and improve the cosmetics from time to time, especially when I have to use some class that I do not understand at first sight because of its structure.
This pull request will contain all my cosmetic and structural changes to the codebase that do not actually change anything to the functionality of the application.
Signed-off-by: Pierre Jaury pierre@jaury.eu