Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Fix some plural messages #1934

Merged
merged 2 commits into from
Mar 2, 2018
Merged

Fix some plural messages #1934

merged 2 commits into from
Mar 2, 2018

Conversation

SafaAlfulaij
Copy link
Contributor

@SafaAlfulaij SafaAlfulaij commented Jan 23, 2018

This will fix some plural messages to be plural aware.

Tests: Not tested, based on logic.

Fixes #1922

Signed-off-by: Safa AlFulaij safa1996alfulaij@gmail.com

@giomfo giomfo requested review from giomfo and Tyuoli February 16, 2018 15:17
@giomfo
Copy link
Member

giomfo commented Feb 19, 2018

@SafaAlfulaij: thank you for your contribution. But you must base your changes on the develop branch - not master (see https://github.com/vector-im/riot-android/blob/master/CONTRIBUTING.rst#how-to-contribute). Could you please update your PR?
It would be great if you can fix the conflict in the NotificationUtils.java file too.

By the way, you will have to sign off your PR (see https://github.com/vector-im/riot-android/blob/master/CONTRIBUTING.rst#sign-off) If you agree, all that's needed is to include the line in your commit or pull request comment:
Signed-off-by: Your Name your@email.example.org

@SafaAlfulaij SafaAlfulaij changed the base branch from master to develop February 19, 2018 17:41
@ylecollen
Copy link
Contributor

LGTM

@ylecollen ylecollen merged commit 16b8466 into element-hq:develop Mar 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[I18N] Fix plural issues in strings
3 participants