This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Use the notification privacy setting screen #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n if the app is registered to GCM
…he app does not use GCM
Tyuoli
approved these changes
Apr 17, 2018
| //UNKNOWN, // the policy has not been set yet | ||
| //NO_NOTIFICATIONS, // no notifications | ||
| } | ||
|
|
There was a problem hiding this comment.
TODO later : create a separate enum class NotificationPrivacy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only in the case of GCM.
#2130
GCM does not need the old "background synchronisation" settings section anymore but it is still required for fallback and f-droid.
I have created an enum(
NotificationPrivacy) that matches what we displayed in this screen but the code still uses booleans combinations.