Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoggingTransaction.executemany should have a proper type hint #15439

Open
matrixbot opened this issue Dec 21, 2023 · 0 comments
Open

LoggingTransaction.executemany should have a proper type hint #15439

matrixbot opened this issue Dec 21, 2023 · 0 comments
Labels
S-Minor T-Task

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 21, 2023 •
edited
Loading

This issue has been migrated from #15439.

executemany is also presumably vulnerable to the same kind of problem?

Originally posted by @DMRobertson in matrix-org/synapse#15432 (comment)

The context here is that we committed a bug to develop that wasn't spotted by tests and wasn't spotted by linting, because the annotation for LoggingTransaction.execute wasn't strict enough. It looks like executemany has a similar problem.
@matrixbot matrixbot changed the title Dummy issue LoggingTransaction.executemany should have a proper type hint Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
This was referenced Oct 31, 2024
Merged
Merged
Merged
Merged
Merged
Merged
MadLittleMods pushed a commit that referenced this issue Oct 31, 2024
@realtyem
Remove Generator from 4 places in PersistEventStore (#17818)
af59a99 
Context: matrix-org/synapse#15439
(#15439)

Also see discussion in #17813
MadLittleMods pushed a commit that referenced this issue Oct 31, 2024
@realtyem
Remove Generator in store_search_entries_txn (#17817)
2e5fe3f 
Context: matrix-org/synapse#15439
(#15439)

Also see discussion in #17813
MadLittleMods pushed a commit that referenced this issue Oct 31, 2024
@realtyem
Remove Generator in update_cached_last_access_time (#17816)
0c429fa 
Context: matrix-org/synapse#15439
(#15439)

Also see discussion in #17813
MadLittleMods pushed a commit that referenced this issue Oct 31, 2024
@realtyem
Remove Generator in _purge_unreferenced_state_groups twice (#17815)
034d472 
Context: matrix-org/synapse#15439
(#15439)

Also see discussion in #17813
MadLittleMods pushed a commit that referenced this issue Oct 31, 2024
@realtyem
Remove Generator in _prune_old_outbound_device_pokes (#17814)
47fe6df 
Context: matrix-org/synapse#15439
(#15439)

Also see discussion in #17813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-Minor T-Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matrixbot