Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare support for Matrix v1.10 #17021

Closed
6 of 8 tasks
clokep opened this issue Mar 22, 2024 · 3 comments · Fixed by #17082
Closed
6 of 8 tasks

Declare support for Matrix v1.10 #17021

clokep opened this issue Mar 22, 2024 · 3 comments · Fixed by #17082

Comments

@clokep
Copy link
Contributor

clokep commented Mar 22, 2024

See matrix-org/synapse#16709 for a previous version of this.

See the changelog (note that I stripped out spec clarifications).


Client-Server API

erikjohnston pushed a commit that referenced this issue Apr 9, 2024
erikjohnston pushed a commit that referenced this issue Apr 9, 2024
See
[MSC4010](matrix-org/matrix-spec-proposals#4010),
but this is pretty much just removing an experimental flag.

Part of #17021
@clokep
Copy link
Contributor Author

clokep commented Apr 9, 2024

@erikjohnston / @anoadragon453 I'd be curious on your thoughts on if Synapse could now declare v1.10 support:

  • Auth for /versions should be accepted by Synape (but ignored) this seems inline with what the MSC proposes.
  • Generally well-known endpoints aren't server by Synapse, and the server support endpoint isn't used by homeservers, so it is "supported".

🤷 Would be curious of opinions.

@anoadragon453
Copy link
Member

* Auth for `/versions` _should_ be accepted by Synape (but ignored) this seems inline with what the MSC proposes.

I agree that we could call the current behaviour of Synapse, where it just ignores attempts at authenticating to /versions, "supporting" MSC4024.

* Generally well-known endpoints aren't server by Synapse, and the server support endpoint isn't used by homeservers, so it is "supported".

I agree that a "homeserver deployment" serving this endpoint via a separate webserver would thus constitute a full homeserver that supports Matrix v1.10. Synapse doesn't need to support serving this endpoint itself in order to declare support for v1.10.

I wouldn't be opposed to declaring v1.10 support before adding an option for Synapse to serve this endpoint itself.

@anoadragon453
Copy link
Member

We discussed it briefly as the Element backend team and had no objections. So, go for it!

erikjohnston pushed a commit that referenced this issue Apr 29, 2024
Pretty straightforward. 😄 

Fixes #17021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants