Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sliding sync: return room tags in account data extension #17694

Closed
erikjohnston opened this issue Sep 11, 2024 · 0 comments · Fixed by #17707
Closed

Sliding sync: return room tags in account data extension #17694

erikjohnston opened this issue Sep 11, 2024 · 0 comments · Fixed by #17707
Assignees
Labels

Comments

@erikjohnston
Copy link
Member

erikjohnston commented Sep 11, 2024

Room tags in Synapse are in a different table than the standard account data tables. We should add them to the room account data section.

This breaks the favourites tab in Element X (EX).

c.f. the handling in sync v2:

ignored_users = await self.store.ignored_users(user_id)
if since_token:
room_changes = await self._get_room_changes_for_incremental_sync(
sync_result_builder, ignored_users
)
tags_by_room = await self.store.get_updated_tags(
user_id, since_token.account_data_key
)
else:
room_changes = await self._get_room_changes_for_initial_sync(
sync_result_builder, ignored_users
)
tags_by_room = await self.store.get_tags_for_user(user_id)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants