Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sliding Sync /sync/e2ee endpoint for To-Device messages #17167

Merged
merged 39 commits into from
May 23, 2024
Merged

Add Sliding Sync /sync/e2ee endpoint for To-Device messages #17167

merged 39 commits into from
May 23, 2024

Commits on May 6, 2024

  1. Configurable /sync/e2ee endpoint

    @MadLittleMods
    MadLittleMods committed May 6, 2024
    Configuration menu
    Copy the full SHA
    f9e6e53 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Add Sliding Sync /sync/e2ee endpoint for To-Device messages 

    Based on:

 - MSC3575: Sliding Sync (aka Sync v3): matrix-org/matrix-spec-proposals#3575
 - MSC3885: Sliding Sync Extension: To-Device messages: matrix-org/matrix-spec-proposals#3885
 - MSC3884: Sliding Sync Extension: E2EE: matrix-org/matrix-spec-proposals#3884
    @MadLittleMods
    MadLittleMods committed May 7, 2024
    Configuration menu
    Copy the full SHA
    1e05a05 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Share tests with test_sendtodevice

    @MadLittleMods
    MadLittleMods committed May 8, 2024
    Configuration menu
    Copy the full SHA
    5e925f6 View commit details
    Browse the repository at this point in the history

  2. Comment on tests

    @MadLittleMods
    MadLittleMods committed May 8, 2024
    Configuration menu
    Copy the full SHA
    69f9143 View commit details
    Browse the repository at this point in the history

  3. Prefer Sync v2 vs Sliding Sync distinction 

    We were using the enum just to distinguish /sync v2
vs Sliding Sync /sync/e2ee so we should just make an
enum for that instead of trying to glom onto the
existing `sync_type` (overloading it).
    @MadLittleMods
    MadLittleMods committed May 8, 2024
    Configuration menu
    Copy the full SHA
    d4ff933 View commit details
    Browse the repository at this point in the history

  4. Fix wait_for_sync_for_user in tests

    @MadLittleMods
    MadLittleMods committed May 8, 2024
    Configuration menu
    Copy the full SHA
    371ec57 View commit details
    Browse the repository at this point in the history

  5. Ugly overloads

    @MadLittleMods
    MadLittleMods committed May 8, 2024
    Configuration menu
    Copy the full SHA
    06d12e5 View commit details
    Browse the repository at this point in the history

  6. Fix lint

    @MadLittleMods
    MadLittleMods committed May 8, 2024
    Configuration menu
    Copy the full SHA
    b8b70ba View commit details
    Browse the repository at this point in the history

  7. Add changelog

    @MadLittleMods
    MadLittleMods committed May 8, 2024
    Configuration menu
    Copy the full SHA
    c60a4f8 View commit details
    Browse the repository at this point in the history

  8. Shared logic for get_sync_result_builder()

    @MadLittleMods
    MadLittleMods committed May 8, 2024
    Configuration menu
    Copy the full SHA
    10ffae6 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Try calculate more

    @MadLittleMods
    MadLittleMods committed May 9, 2024
    Configuration menu
    Copy the full SHA
    6bf4896 View commit details
    Browse the repository at this point in the history

  2. Share tests using inheritance 

    See #17167 (comment)
-> https://stackoverflow.com/questions/28333478/python-unittest-testcase-with-inheritance
    @MadLittleMods
    MadLittleMods committed May 9, 2024
    Configuration menu
    Copy the full SHA
    8871dac View commit details
    Browse the repository at this point in the history

  3. Add comments docs

    @MadLittleMods
    MadLittleMods committed May 9, 2024
    Configuration menu
    Copy the full SHA
    0892283 View commit details
    Browse the repository at this point in the history

  4. Consolidate device_lists /sync tests

    @MadLittleMods
    MadLittleMods committed May 9, 2024
    Configuration menu
    Copy the full SHA
    adb7e20 View commit details
    Browse the repository at this point in the history

  5. Add device_one_time_keys_count tests

    @MadLittleMods
    MadLittleMods committed May 9, 2024
    Configuration menu
    Copy the full SHA
    f098355 View commit details
    Browse the repository at this point in the history

  6. Add tests for device_unused_fallback_key_types in /sync

    @MadLittleMods
    MadLittleMods committed May 9, 2024
    Configuration menu
    Copy the full SHA
    6b7cfd7 View commit details
    Browse the repository at this point in the history

  7. Describe test

    @MadLittleMods
    MadLittleMods committed May 9, 2024
    Configuration menu
    Copy the full SHA
    b9e5379 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Merge branch 'develop' into madlittlemods/msc3575-sliding-sync-e2ee 

    Conflicts:
	synapse/handlers/sync.py
	tests/handlers/test_sync.py
    @MadLittleMods
    MadLittleMods committed May 16, 2024
    Configuration menu
    Copy the full SHA
    9bdfa16 View commit details
    Browse the repository at this point in the history

  2. Lint

    @MadLittleMods
    MadLittleMods committed May 16, 2024
    Configuration menu
    Copy the full SHA
    7331401 View commit details
    Browse the repository at this point in the history

  3. Fix test inheritance 

    See #17167 (comment)
    @MadLittleMods
    MadLittleMods committed May 16, 2024
    Configuration menu
    Copy the full SHA
    b23abca View commit details
    Browse the repository at this point in the history

  4. Add missing field to docstring

    @MadLittleMods
    MadLittleMods committed May 16, 2024
    Configuration menu
    Copy the full SHA
    821a1b3 View commit details
    Browse the repository at this point in the history

  5. Format docstring

    @MadLittleMods
    MadLittleMods committed May 16, 2024
    Configuration menu
    Copy the full SHA
    35ca937 View commit details
    Browse the repository at this point in the history

  6. No need to change this formatting from develop

    @MadLittleMods
    MadLittleMods committed May 16, 2024
    Configuration menu
    Copy the full SHA
    4ad7a8b View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Calculate room derived membership info for device_lists 

    See #17167 (comment)
    @MadLittleMods
    MadLittleMods committed May 20, 2024
    Configuration menu
    Copy the full SHA
    3092ab5 View commit details
    Browse the repository at this point in the history

  2. Membership in timeline for better derived info

    @MadLittleMods
    MadLittleMods committed May 20, 2024
    Configuration menu
    Copy the full SHA
    3539abe View commit details
    Browse the repository at this point in the history

  3. Exclude application services 

    See #17167 (comment)
    @MadLittleMods
    MadLittleMods committed May 20, 2024
    Configuration menu
    Copy the full SHA
    5f194f9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into madlittlemods/msc3575-sliding-sync-e2ee

    @MadLittleMods
    MadLittleMods committed May 20, 2024
    Configuration menu
    Copy the full SHA
    02cecfa View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Use client_patterns() for endpoint URL 

    See #17167 (comment)
    @MadLittleMods
    MadLittleMods committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f6122ff View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into madlittlemods/msc3575-sliding-sync-e2ee

    @MadLittleMods
    MadLittleMods committed May 21, 2024
    Configuration menu
    Copy the full SHA
    2f112e7 View commit details
    Browse the repository at this point in the history

  3. Lint

    @MadLittleMods
    MadLittleMods committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c2221bb View commit details
    Browse the repository at this point in the history

  4. Adjust wording, add todo

    @MadLittleMods
    MadLittleMods committed May 21, 2024
    Configuration menu
    Copy the full SHA
    717b160 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Merge branch 'develop' into madlittlemods/msc3575-sliding-sync-e2ee 

    Conflicts:
	synapse/handlers/sync.py
    @MadLittleMods
    MadLittleMods committed May 22, 2024
    Configuration menu
    Copy the full SHA
    514aba5 View commit details
    Browse the repository at this point in the history

  2. Update filter to be more precise and avoid more work 

     - Added `room.account_data` and `room.presence` to avoid extra work in `_generate_sync_entry_for_rooms()`
 - Added a comment to the top-level `account_data` and `presence` filters that `(This is just here for good measure)`

See #17167 (comment)
    @MadLittleMods
    MadLittleMods committed May 22, 2024
    Configuration menu
    Copy the full SHA
    9749795 View commit details
    Browse the repository at this point in the history

  3. Restore copyright header 

    See #17167 (comment)
    @MadLittleMods
    MadLittleMods committed May 22, 2024
    Configuration menu
    Copy the full SHA
    06ac1da View commit details
    Browse the repository at this point in the history

  4. Use @parameterized_class 

    As suggested in #17167 (comment)
    @MadLittleMods
    MadLittleMods committed May 22, 2024
    Configuration menu
    Copy the full SHA
    3da6bc1 View commit details
    Browse the repository at this point in the history

  5. Fix lints

    @MadLittleMods
    MadLittleMods committed May 22, 2024
    Configuration menu
    Copy the full SHA
    d4b41aa View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Add docstring for parametized attributes 

    See #17167 (comment)
    @MadLittleMods
    MadLittleMods committed May 23, 2024
    Configuration menu
    Copy the full SHA
    6606ac1 View commit details
    Browse the repository at this point in the history

  2. Add actual typing for params (not just docstrings) 

    See #17167 (comment)
    @MadLittleMods
    MadLittleMods committed May 23, 2024
    Configuration menu
    Copy the full SHA
    ab0b844 View commit details
    Browse the repository at this point in the history

  3. Fix test after removing type ignore

    @MadLittleMods
    MadLittleMods committed May 23, 2024
    Configuration menu
    Copy the full SHA
    a482545 View commit details
    Browse the repository at this point in the history