Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sliding Sync: Only send rooms with updates down sliding sync #17479

Merged
merged 56 commits into from
Jul 30, 2024
Merged

Sliding Sync: Only send rooms with updates down sliding sync #17479

merged 56 commits into from
Jul 30, 2024

Commits on Jul 17, 2024

  1. Add SlidingSyncStreamToken

    @erikjohnston
    erikjohnston committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    30263b4 View commit details
    Browse the repository at this point in the history

  2. Pass throught SlidingSyncStreamToken

    @erikjohnston
    erikjohnston committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    1ad1cce View commit details
    Browse the repository at this point in the history

  3. Don't create tokens manually in SSS tests

    @erikjohnston
    erikjohnston committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e8df0d7 View commit details
    Browse the repository at this point in the history

  4. Fix to use new token format

    @erikjohnston
    erikjohnston committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f3030af View commit details
    Browse the repository at this point in the history

  5. Newsfile

    @erikjohnston
    erikjohnston committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f3a4cfb View commit details
    Browse the repository at this point in the history

  6. WIP/PoC of storing whether we have sent rooms down to clients

    @erikjohnston
    erikjohnston committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    d44f7e1 View commit details
    Browse the repository at this point in the history

  7. Add conn_id field

    @erikjohnston
    erikjohnston committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    53273db View commit details
    Browse the repository at this point in the history

  8. Use new room store to track if we've sent a room down

    @erikjohnston
    erikjohnston committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e2a88e4 View commit details
    Browse the repository at this point in the history

  9. Handle initial flag correctly

    @erikjohnston
    erikjohnston committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    1858317 View commit details
    Browse the repository at this point in the history

  10. Handle state deltas in non-initial rooms

    @erikjohnston
    erikjohnston committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    de6e3bd View commit details
    Browse the repository at this point in the history

  11. Fix tests

    @erikjohnston
    erikjohnston committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e2c47bf View commit details
    Browse the repository at this point in the history

  12. Newsfile

    @erikjohnston
    erikjohnston committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    a90c408 View commit details
    Browse the repository at this point in the history

  13. Bump typing-extensions for 'assert_never'

    @erikjohnston
    erikjohnston committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    2968f2e View commit details
    Browse the repository at this point in the history

  14. Add tests

    @erikjohnston
    erikjohnston committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    2784881 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Add docstring

    @erikjohnston
    erikjohnston committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    d689204 View commit details
    Browse the repository at this point in the history

  2. Remove '_token' prefix

    @erikjohnston
    erikjohnston committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    560087b View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Eric Eastwood <eric.eastwood@beta.gouv.fr>
    @erikjohnston @MadLittleMods
    erikjohnston and MadLittleMods committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    40d9587 View commit details
    Browse the repository at this point in the history

  4. Reword doc

    @erikjohnston
    erikjohnston committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    14eb781 View commit details
    Browse the repository at this point in the history

  5. Keyword args

    @erikjohnston
    erikjohnston committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    9ae2551 View commit details
    Browse the repository at this point in the history

  6. Rename bounds

    @erikjohnston
    erikjohnston committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    51f7602 View commit details
    Browse the repository at this point in the history

  7. Add context to conn_id

    @erikjohnston
    erikjohnston committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    eab092b View commit details
    Browse the repository at this point in the history

  8. Refactor to avoid SyncConfig.connection_id()

    @erikjohnston
    erikjohnston committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    605b358 View commit details
    Browse the repository at this point in the history

  9. Add some unit tests for 'get_room_sync_data'

    @erikjohnston
    erikjohnston committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    37c4463 View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'origin/develop' into erikj/ss_room_store

    @erikjohnston
    erikjohnston committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    7f26fc4 View commit details
    Browse the repository at this point in the history

  11. Fix linting in tests

    @erikjohnston
    erikjohnston committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    532594e View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Merge remote-tracking branch 'origin/develop' into erikj/ss_tokens

    @erikjohnston
    erikjohnston committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    1230a51 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'erikj/ss_tokens' into erikj/ss_room_store

    @erikjohnston
    erikjohnston committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    01f1dca View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Eric Eastwood <eric.eastwood@beta.gouv.fr>
    @erikjohnston @MadLittleMods
    erikjohnston and MadLittleMods committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    6f738a4 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into erikj/ss_tokens

    @erikjohnston
    erikjohnston committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    588dfb8 View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @erikjohnston
    erikjohnston committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    0c4e633 View commit details
    Browse the repository at this point in the history

  4. Change token names again

    @erikjohnston
    erikjohnston committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    60790d6 View commit details
    Browse the repository at this point in the history

  5. Ensure there is only one SlidingSyncHandler

    @erikjohnston
    erikjohnston committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    4ce3e51 View commit details
    Browse the repository at this point in the history

  6. Add test for cache being cleared

    @erikjohnston
    erikjohnston committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    602b6c8 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'erikj/ss_tokens' into erikj/ss_room_store

    @erikjohnston
    erikjohnston committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e2f3d48 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Merge remote-tracking branch 'origin/develop' into erikj/ss_room_store

    @erikjohnston
    erikjohnston committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    81b2162 View commit details
    Browse the repository at this point in the history

  2. Only send rooms with updates down sliding sync

    @erikjohnston
    erikjohnston committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    75f7c01 View commit details
    Browse the repository at this point in the history

  3. Newsfile

    @erikjohnston
    erikjohnston committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    b36cada View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Update comments

    @erikjohnston
    erikjohnston committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    0812894 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into erikj/ss_room_store

    @erikjohnston
    erikjohnston committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    66f80cc View commit details
    Browse the repository at this point in the history

  3. Use do_sync in tests

    @erikjohnston
    erikjohnston committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    2c48784 View commit details
    Browse the repository at this point in the history

  4. Move to integration tests

    @erikjohnston
    erikjohnston committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    abd7a5b View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Review comments

    @erikjohnston
    erikjohnston committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    470c5d3 View commit details
    Browse the repository at this point in the history

  2. Previously state test

    @erikjohnston
    erikjohnston committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    90f2184 View commit details
    Browse the repository at this point in the history

  3. Add never test

    @erikjohnston
    erikjohnston committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    e7a6c19 View commit details
    Browse the repository at this point in the history

  4. Review comments

    @erikjohnston
    erikjohnston committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    b9facaf View commit details
    Browse the repository at this point in the history

  5. Add test that empty room comes down initial sync

    @erikjohnston
    erikjohnston committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    b396450 View commit details
    Browse the repository at this point in the history

  6. Make it clear we only filter out rooms in incremental sync

    @erikjohnston
    erikjohnston committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    c56a745 View commit details
    Browse the repository at this point in the history

  7. Don't send down rooms if nothing has happened

    @erikjohnston
    erikjohnston committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    c53e83d View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/erikj/ss_room_store' into erikj/… 

    …ss_noop_rooms
    @erikjohnston
    erikjohnston committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    1740f11 View commit details
    Browse the repository at this point in the history

  9. Add dedicated function 'get_rooms_that_might_have_updates'

    @erikjohnston
    erikjohnston committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    fd61672 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Eric Eastwood <eric.eastwood@beta.gouv.fr>
    @erikjohnston @MadLittleMods
    erikjohnston and MadLittleMods committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    7ae5f78 View commit details
    Browse the repository at this point in the history

  2. Add clarifying comments

    @erikjohnston
    erikjohnston committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    76c69e6 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/develop' into erikj/ss_noop_rooms

    @erikjohnston
    erikjohnston committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    d043009 View commit details
    Browse the repository at this point in the history

  4. Fix comment

    @erikjohnston
    erikjohnston committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    4646edb View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Eric Eastwood <eric.eastwood@beta.gouv.fr>
    @erikjohnston @MadLittleMods
    erikjohnston and MadLittleMods committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    7088cb0 View commit details
    Browse the repository at this point in the history

  6. Change comment and andd assertion

    @erikjohnston
    erikjohnston committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    07c0561 View commit details
    Browse the repository at this point in the history