First cut of the red list module #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babolivier
added
the
Z-Time-Tracked
babolivier
force-pushed
the
babolivier/init
branch
from
e38bd49
to
29a9644
Compare
squahtx
reviewed
Apr 8, 2022
babolivier
commented
Apr 11, 2022
Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
|
@babolivier Did you forget to push changes or publish replies? |
… into babolivier/init
|
@squahtx I did forget to push my changes 🤦 thanks for noticing, should be good now |
Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the Tchap mainlining.
This is in order to implement the new plan for user discovery. See matrix-org/synapse-dinsic#125 for the high-level description and https://docs.google.com/document/d/1wQw1OMgqn0blbv4Jt7ApZhR8mtN39ZLkNHKuNY-Xd_M/edit for the detailed action plan (which this work is a part of) and specification this module implements.
An upcoming PR will add the interoperability with https://github.com/matrix-org/synapse-email-account-validity that's described in the doc (hence why this one includes references to an "expired" status).
Linters are not expected to pass until matrix-org/synapse#12327 is released with Synapse 1.57, but I've ran them locally and they're passing.
Tests are not expected to pass until matrix-org/synapse#12246 is released with Synapse 1.56, but I've ran them locally and they're passing.
The diff looks a bit scary but most of it is a copy-pasted mypy plugin from Synapse and some tests.