Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): [upload] added index parameter to default slot #17143

Merged
merged 5 commits into from
Aug 7, 2024

Conversation

zhuchaoling
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Copy link

👋 @zhuchaoling, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jun 10, 2024
Copy link

github-actions bot commented Jun 10, 2024

Copy link

Hello @zhuchaoling, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@btea
Copy link
Member

btea commented Jun 11, 2024

Can you describe your usage scenario?

@zhuchaoling
Copy link
Contributor Author

Can you describe your usage scenario?

自定义文件样式时,删除文件有点麻烦。传index后,直接splice,很ok

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jun 11, 2024
@btea
Copy link
Member

btea commented Jun 11, 2024

Perhaps the relevant parameters in the document also need to be updated synchronously.

Copy link

github-actions bot commented Jun 11, 2024

🧪 Playground Preview: https://element-plus.run/?pr=17143
Please comment the example via this playground if needed.

@zhuchaoling
Copy link
Contributor Author

Perhaps the relevant parameters in the document also need to be updated synchronously.

Do I need to update the document, or will you do the update?

@btea
Copy link
Member

btea commented Jun 11, 2024

Yes, you can update it.

@btea btea changed the title fix(components): add the index attribute to the upload-list component feat(components): [upload] added index parameter to default slot Jun 11, 2024
@zhuchaoling
Copy link
Contributor Author

slot

updatedupdated

@btea
Copy link
Member

btea commented Jun 11, 2024

It seems you haven't committed any new code.

@zhuchaoling
Copy link
Contributor Author

It seems you haven't committed any new code.

Oh sorry, I forgot to push the code. It's okay now.

@btea
Copy link
Member

btea commented Jun 12, 2024

Since index is not passed here, the file slot should not get the corresponding value.

<slot name="file" :file="file" />

@zhuchaoling
Copy link
Contributor Author

Since index is not passed here, the file slot should not get the corresponding value.

<slot name="file" :file="file" />

okay already updated

@zhuchaoling
Copy link
Contributor Author

Since index is not passed here, the file slot should not get the corresponding value.

<slot name="file" :file="file" />

Many thanks for your review.

@btea
Copy link
Member

btea commented Jun 26, 2024

@zhuchaoling Hello, it seems that you have taken the initiative to close this PR?

@zhuchaoling
Copy link
Contributor Author

reopen,Many thanks for your check.

@zhuchaoling zhuchaoling reopened this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants