Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support evolution data server 3.45+ / libsoup-3.0 / geocode-glib-2.0 #756

Closed
bobby285271 opened this issue Aug 1, 2022 · 6 comments
Closed

Comments

@bobby285271
Copy link
Member

bobby285271 commented Aug 1, 2022

Not sure if this is really an issue that should be resolved before/during GNOME 43 cycle or just because of me didn't packaged everything properly yet. Building this with evolution data server 3.45.1 fails for me and I think maybe it is caused by libsoup-2.4 clashes with libsoup-3.0, here is the full log:

https://gist.github.com/bobby285271/1a19d13bab9146d0824de0e2a82aa5ac

P.s.: I also mentioned geocode-glib-2.0 in the title as it is built against libsoup-3.0.


Actually I am trying to port this but stuck on this line:

var uri = webdav.dup_soup_uri ();

Is replacing it with dup_uri only possible on 3.46 due to this? Was getting:

../plugins/CalDAV/CalDAVBackend.vala:77.23-77.36: error: `E.SourceWebdav.dup_uri' is not available in libedataserver-1.2 3.45.1. Use libedataserver-1.2 >= 3.46
   77 |             var uri = webdav.dup_uri ();
      |                       ^~~~~~~~~~~~~~ 
@decathorpe
Copy link
Contributor

Hum, yes, calendar is also broken with e-d-s 3.45.1 on Fedora. It appears that I forgot to file a bug about this one, I filed tickets for all the others. Weird.

@decathorpe
Copy link
Contributor

decathorpe commented Aug 1, 2022

Building this with evolution data server 3.45.1 fails for me and I think maybe it is caused by libsoup-2.4 clashes with libsoup-3.0, here is the full log:

I'm seeing similar (or the same) build problems on Fedora. This means that something is pulling in libsoup 2.4 development headers. Turns out, the culprit is calendar itself (or at least, one of the culprits):
https://github.com/elementary/calendar/blob/master/meson.build#L31

I think this needs a similar conditional (i.e. if e-d-s >= 3.45.1, depend on libsoup-3, else, depend on libsoup-2) to the ones you submitted for other projects, and it might just work (maybe with minor code adaptations for changed APIs, like the Soup.URI removal).

@bobby285271
Copy link
Member Author

bobby285271 commented Aug 6, 2022

I finally managed to build and launch the app, I think we will at least need:

@bobby285271
Copy link
Member Author

bobby285271 commented Sep 17, 2022

Looks like my previous testing is done in an improper way, it looks like with #758 applied and everything GNOME 43.rc and the libchamplain MR and Eds 3.46 (it's out!) both wingpanel-indicator-datetime and calendar does not show any date numbers 😞

@bobby285271
Copy link
Member Author

Ah it looks like I resolved #756 (comment) with bobby285271@7f3a4be so probably that is not really related to the e-d-s bump (I still not sure what happened though) 🙈

@meisenzahl
Copy link
Member

Should be closed by #756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants