Application: Add Calendar.Settings Singleton
#733
Conversation
This class replaces the old Maya.Settings namespace and provide access to internal and external properties even when sandboxed. For internal settings, this will use the GLib.Settings if disponible. For external settings, this will first try to use the portal, fallbacking to the GLib.Settings if it fails for any reason.
Also, remove the now unneeded settings from Application.vala
|
|
||
| // application settings | ||
| public DateTime date { get; set; } | ||
| public WindowState window { get; set; } |
There was a problem hiding this comment.
I would name this property as e.g. window_state since a window is already a thing.
| string day = saved_state.get_string ("selected-day"); | ||
| string month = saved_state.get_string ("month-page"); | ||
|
|
||
| if ( day != "" || month != "") { |
There was a problem hiding this comment.
| if ( day != "" || month != "") { | |
| if (day != "" || month != "") { |
| } | ||
|
|
||
| d = int.parse (split[1]); | ||
| } |
There was a problem hiding this comment.
Wouldn't it be better to use string.scanf here together with the same format strings used write the settings?
| } | ||
|
|
||
| private static DateWeekday parse_weekday_name (Variant variant) { | ||
| switch (variant.get_string ()) { |
There was a problem hiding this comment.
Maybe force lower case as this might be fed user edited values?
|
Some conflicts with main to sort through :) |
|
Well, with the bakground portal not needing this anymore, and with the first_weekday PR closed, i think this PR lost purpose, for now. unless the ability to run without the schemas installed is a much wanted feature, what i doubt it is. |
|
That really only seems useful for some dev testing scenarios. Granted this was given to the OS 7.1 project and is part of the upcoming release draft so maybe @danirabbit can confirm if this should stay or not. |
|
Ah yeah i think this was on the project because at the time it was background portal related maybe? We can bump it off it doesn’t seem like it’s currently useful |
|
Based on the last few messages it sounds like this can be closed. |
Second part of elementary/settings-daemon#39.
This create an new
Calendar.Settingsclass to provide both internal and external settings, while allowing calendar to work ever if they can't access any of the settings (eg. running./build/src/io.elementary.calendar).this is exposing two unused keys right now:
Maya.Settingswas removed andtime_format ()moved there.