Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix meson warning for run_command #762

Merged
merged 3 commits into from
May 10, 2023

Conversation

turbobastii
Copy link
Contributor

Since I am already fixing the other repos with this issue, I thought I might do it here aswell.

TLDR: meson will change the default behaviour of run_command and displays that as a warning when building.
See: mesonbuild/meson#9300

image

@tintou
Copy link
Member

tintou commented Oct 1, 2022

Don't we want it to be true?

@turbobastii
Copy link
Contributor Author

Well it was false implicitly by default, but if you think it would make more sense if it was true, I can of course change it.

@eli-schwartz
Copy link

eli-schwartz commented Oct 2, 2022

Well it was false implicitly by default

If the implicit default was generally good, then we (Meson) would not have deprecated it in the hope of eventually changing the default. :)

When adding an explicit value, it is wisest to consider what that value would be best served by being, rather than just explicating the default purely to quell the warning.

...

i.e. It's quite likely that if the command failed, the build is broken and will error out for quite mysterious reasons slightly later on -- best to validate it early...

@turbobastii
Copy link
Contributor Author

Very well put, thank you. I changed it accordingly.

@lenemter lenemter enabled auto-merge (squash) May 10, 2023 11:03
@lenemter lenemter merged commit b0e81b8 into elementary:master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants