Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style updates #780

Merged
merged 8 commits into from
Jul 20, 2023
Merged

Style updates #780

merged 8 commits into from
Jul 20, 2023

Conversation

leolost2605
Copy link
Member

These changes are a suggestion please reject if they don't make sense designwise :)

Use system accent color instead of a custome one
Slide months right/left instead up/down
@leolost2605 leolost2605 requested review from a team April 30, 2023 20:30
zeebok
zeebok previously approved these changes May 13, 2023
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise this looks fine. Definitely agree that UX needs to weigh in on what they think

@danirabbit danirabbit mentioned this pull request Jun 13, 2023
3 tasks
@zeebok
Copy link
Contributor

zeebok commented Jul 7, 2023

@danirabbit can we consider you adding this to the release as a thumbs up to using user accent color?

@zeebok zeebok dismissed their stale review July 9, 2023 02:24

Could use some clean-up

data/style/Application.css Outdated Show resolved Hide resolved
@leolost2605 leolost2605 requested a review from zeebok July 20, 2023 12:53
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me now and confirmed to work :)

@zeebok zeebok merged commit 50aefad into master Jul 20, 2023
@zeebok zeebok deleted the style-updates branch July 20, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Scrolling happens vertically but buttons indicate paging horizontally
4 participants