Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "You are now offline" notifications #290

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Sep 5, 2023

Fixes #145

@lenemter lenemter requested a review from a team September 5, 2023 08:27
@TomiOhl
Copy link

TomiOhl commented Sep 5, 2023

Hmm it might be only me but I've disabled these once and had to google to enable them again.
Iirc this notification has a "Don't show again" button, so imo if anyone is bothered, they can just click it once and never again
Also the issue is rather about the case when the wifi is disabled by the user but would like to keep the notification for the case when the connection is lost for any other reason

@lenemter lenemter marked this pull request as draft November 11, 2023 14:27
@danirabbit
Copy link
Member

@TomiOhl can you open a feature request against the network indicator to add an option to send network disconnected notifications? I think regardless we need to send them there and disable these so that we don't send them when a person disconnects manually

@danirabbit danirabbit marked this pull request as ready for review January 9, 2024 19:23
@danirabbit danirabbit merged commit f60cbd0 into master Jan 9, 2024
3 checks passed
@danirabbit danirabbit deleted the lenemter/disable-disconnected-notifications branch January 9, 2024 19:23
@TomiOhl
Copy link

TomiOhl commented Jan 9, 2024

Sure Danielle, opened elementary/wingpanel-indicator-network#313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Feature request: Do not display notification if I disable wifi myself
4 participants