BookmarkRow: Remove plank PoofWindow effect (#2356)

.github/workflows/main.yml

@@ -25,7 +25,7 @@ jobs:
       run: |
         apt update
         apt install -y libgee-0.8-dev libglib2.0-dev libgranite-dev libgtk-3-dev libhandy-1-dev libcanberra-dev
-        apt install -y libcloudproviders-dev libdbus-glib-1-dev libpango1.0-dev libplank-dev
+        apt install -y libcloudproviders-dev libdbus-glib-1-dev libpango1.0-dev
         apt install -y libsqlite3-dev libunity-dev libzeitgeist-2.0-dev policykit-1 libgit2-glib-1.0-dev
         apt install -y meson valac
     - name: Build

README.md

@@ -19,7 +19,6 @@ You'll need the following dependencies:
 * libgtk-3-dev
 * libhandy-1-dev >= 1.2.0
 * libpango1.0-dev
-* libplank-dev
 * libsqlite3-dev
 * libunity-dev
 * libzeitgeist-2.0-dev

meson.build

@@ -68,8 +68,6 @@ posix_dep = vala.find_library('posix')
 linux_dep = vala.find_library('linux')
 math_dep = cc.find_library('m')
 
-plank_dep = dependency('plank', version: '>=0.10.9')
-
 zeitgeist_dep = dependency('zeitgeist-2.0', required: get_option('with-zeitgeist'))
 if (zeitgeist_dep.found())
     add_project_arguments('--define=HAVE_ZEITGEIST', language: 'vala')

src/View/Sidebar/BookmarkRow.vala

@@ -362,30 +362,6 @@ public class Sidebar.BookmarkRow : Gtk.ListBoxRow, SidebarItemInterface {
             sel_data.@set (text_data_atom, 8, data);
         });
 
-        drag_failed.connect ((ctx, res) => {
-            if (res == Gtk.DragResult.NO_TARGET) {
-                Gdk.Window app_window = list.list_box.get_window ().get_effective_toplevel ();
-                Gdk.Window drag_window = ctx.get_drag_window ();
-                Gdk.Rectangle app_rect, drag_rect, intersect_rect;
-
-                app_window.get_frame_extents (out app_rect);
-                drag_window.get_frame_extents (out drag_rect);
-
-                if (!drag_rect.intersect (app_rect, out intersect_rect)) {
-                    list.remove_item_by_id (id);
-                    var device = ctx.get_device ();
-                    int x, y;
-                    device.get_position (null, out x, out y);
-                    Plank.PoofWindow poof_window;
-                    poof_window = Plank.PoofWindow.get_default ();
-                    poof_window.show_at (x, y);
-                    return true;
-                }
-            }
-
-            return false;
-        });
-
         drag_end.connect ((ctx) => {
             reset_drag_drop ();
         });

src/meson.build

@@ -2,7 +2,6 @@ pantheon_files_deps = [
     common_deps,
     handy_dep,
     pantheon_files_core_dep,
-    plank_dep,
     zeitgeist_dep,
     project_config_dep,
 ]