-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android phone is not accessible in Odin [screenshots] #1781
Comments
I'm unable to reproduce this here with a Pixel 3 or Pixel 5 on both Android 11 and the upcoming Android 12; plugging in prompts me on the phone, and I can choose "File transfer" to enable USB file transferring. |
Well, very bad for me. The only difference between the two OS installations on my end is that Odin is on the new SSD while Hera is on an HDD. That's it. All the rest is the same (the system specs etc). Please guide me to test the same "from other angles" (if there are). |
Hi It happened to me... the same thing with the same phone. Right now is working as it should be but I wanted to share my experience in case could help you.
the directory that is created now (working scenario) is: previously with this device its hostname was (wasn't working): I really don't remember what I changed in the phone but looks like there's something about the device hostname that creates the problem... maybe the colon in it? I found another bug with mount points, samba shares and devices but that isn't the issue here. This logs are from now (working scenario)
syslog: opening Files
syslog: transfer activation in the phone
dmesg
my system: |
I could reproduce this issue on my Android phone using the current master code, but using PR #1752 I could successfully connect to the internal storage on the phone (once the USB connected device was set to "File Transfer" on the phone settings.) |
Hello, dmesg journalctl mtp-detect Listing raw device(s) |
@rscm what do you suggest I should do to fix? I didn't quite get you. |
nothing, is pretty clear what I wrote
|
thanks @rscm it took me while to understand workaround. Files are accessible via Terminal. Thanks! |
I am still facing this issue on elementary 6.1. I can access it using the terminal as suggested @rscm but again has limited usability as in, if you want to look at image thumbnails while copying only specific images from the phone. |
@agrawalsourav98 Which folder path are you looking at when you access the phone through the terminal? If the phone mounts and creates a readable folder under |
@jeremypw I have a oneplus 7 pro running android 11. I have previously used other mtp tools such as android file transfer and I was able to transfer files as usual. Also the mount point has no issues while using the terminal. With MTP: With PTP: |
Maybe to do with the colon in the address being sought - I do not get that. I'll see if Files can be fixed to deal with that sort of address. |
@agrawalsourav98 If you can, could you try out the linked PR to see whether it fixes the problem? |
I would like to try that fix over here, but I need to ask something about the build process. After I execute |
@o-alquimista Just don't use |
No, its still the same, I think when mounting the device `%3A' should not be in the mount folder name. But also for some reason the mount location searched by files is cut short till 1680. Results on current PR, |
The PR doesn't fix it. The actual mtp mountpoint is this:
You can But Files tries to access this (which doesn't exist):
|
@agrawalsourav98 OK, thanks for trying. I cannot do anything about the path under |
By the way, could you just make sure that all existing Files processes are killed before launching the PR locally? It is possible that it is still using the unmodified library. |
Yes, tried it with using Or would just skipping the colon escape in files make more sense? |
The colon is usually a reserved character when escaping uris as it is needed for the protocol and possibly port so I think we need to special case MTP and PTP addresses and escape any colon that occurs after the one in the protocol - that is what the PR was doing except that I now see that it is being undone by Directory also processing the uri. So I will soon push a new version that leaves the special processing to Directory. |
Yes, got it. So, the escaping is necessary on gvfs end to allow mounting of devices with special characters. Cool, waiting to try the above mentioned fix! |
@agrawalsourav98 I've now updated #1977 so I'll be interested to hear whether it works for you. Tbh, the handling of various types of URI (including user input) in Files has become rather convoluted as various fixes and workarounds have been incorporated over the years and probably requires a rethink to see whether it can be simplified or at least made more intelligible. |
Yep, that just fixed it. It just makes sense to escape the colon as the underlying gvfs explicitly does that. I completely agree. There are a few things I face as well, like when I try to paste some stuff into the address bar, it automatically prefixes the current dir, it doesn't take into account if the path is absolute or relative. Maybe I will try to spare some free time to see if I can fix any. BTW when is this fix making the release? |
The fix needs to be tested for regressions, reviewed and approved so it could be a while for it to get released. As it is relatively simple, hopefully it will not be too long. It will get into the unstable version earlier. |
What Happened
In the Odin release, Android phone connected via USB cable is not accessible. It connects and shows three options on the phone, none works.
Please refer to the screenshots below for comparison in Odin and Hera versions of the OS.
In Odin:
While it worked totally fine in Hera:
Expected Behavior
I should be able to access the entire phone as usual.
Steps to Reproduce
Logs
Platform Information
OS: elementary OS 6 Odin
CPU: Intel i5 3330
Mobo: Intel DH61WW
RAM: 6GB
Phone: Redmi Note 10 running MIUI 12.0.4
The text was updated successfully, but these errors were encountered: