Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browsing mtp/ptp devices with a colon in the device name #1977

Merged
merged 10 commits into from
Feb 23, 2023

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Jan 8, 2022

Fixes #1781

Addresses problem with the address given by certain devices connected with MTP or PTP protocol.
Also removes unnecessary related MTP code and ensures that the tab name is unescaped (required to prevent regression)

@jeremypw jeremypw changed the title Escape possible colon in mtp/ptp devicename Fix browsing mtp/ptp devices with a colon in the device name Jan 10, 2022
@jeremypw
Copy link
Collaborator Author

Fix confirmed by original reporter.

@danirabbit danirabbit requested a review from a team June 9, 2022 18:45
@jeremypw jeremypw mentioned this pull request Feb 22, 2023
6 tasks
@jeremypw jeremypw merged commit 6e8ea6e into master Feb 23, 2023
@jeremypw jeremypw deleted the fix-mtp-colon-devicename branch February 23, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android phone is not accessible in Odin [screenshots]
3 participants