Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not automatically select files created outside of application #2023

Merged
merged 10 commits into from
Mar 7, 2023
Merged

Do not automatically select files created outside of application #2023

merged 10 commits into from
Mar 7, 2023

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Apr 12, 2022 •
edited
Loading

Fixes #2022

  • Add another flag to Files.FileChanges.Change
  • Pass Change to Directory when notifying additions
  • Pass Change.is_internal when signalling file_added
  • Only select files when is_internal true

Consequential changes

  • Dont pass delegate to Directory.query_info_async - use callback closure (so does not need fixed signature)

Other types of file changes are handled as before - the is_internal flag defaults to true and is ignored.

@danirabbit danirabbit requested a review from tintou April 12, 2022 20:00
@jeremypw jeremypw requested a review from mcclurgm February 9, 2023 17:13
@jeremypw jeremypw requested a review from a team February 19, 2023 18:45
@jeremypw jeremypw changed the title Distinguish internal and external change in FileChanges; Do not automatically select files created outside of application Mar 6, 2023
zeebok
zeebok approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised!

@jeremypw jeremypw merged commit 4f5cb2a into master Mar 7, 2023
@jeremypw jeremypw deleted the no-select-externally-created branch March 7, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok approved these changes

@tintou tintou Awaiting requested review from tintou

@mcclurgm mcclurgm Awaiting requested review from mcclurgm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not automatically select files created outside of application
2 participants
@jeremypw @zeebok