Rewrite overwrite prompt for link case #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marukesu
reviewed
Jun 11, 2022
|
@mcclurgm I have tried to fix this consistent with @Marukesu 's suggestions (although I have reworked the string handling a little differently). It now compiles and seems to work with the builtin portal tester and also the Flatpak version of Code. I have little experience of documenting functions - I have tried to follow the format in existing projects but there may be some tweaking required. |
|
@Marukesu Could cast another eye over this? Particularly the method documentation I added. The CI failure is not related to this PR - it seems to be happening to all PRs merged with the current master but I haven't determined the reason yet (it doesn't happen locally so something to do with the container?) |
Marukesu
reviewed
Feb 21, 2023
Co-authored-by: Gustavo Marques <pushstarttocontinue@outlook.com>
jeremypw
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #1989. Split into a separate PR so the functionality of the main one could be merged.
I think this is a more understandable wording for this case. I am open to feedback on this though.
Note that it fails to compile, seemingly because the result of
printfis owned, butprimaryandsecondaryare unowned. I'm not quite sure how to fix this.I also added a doc comment for
create_overwrite_dialogwhile here.