Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix case sensitivity when providing completions for paths #2059

Merged
merged 8 commits into from
Feb 23, 2023
Merged

Fix case sensitivity when providing completions for paths #2059

merged 8 commits into from
Feb 23, 2023

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Jun 27, 2022 •
edited
Loading

Fixes #1997

  • Compute completion only after iterating through all files
  • Make work with non-Latin characters
  • Improve some variable names
  • Keep trailing separator when focusing in so can start typing subpath immediately

Jeremy Wootten added 4 commits June 27, 2022 08:15
Add a done_loading callback as a parameter for Directory.init ()
4163f2e
Refactor completion
1b4dd1a 
* Move some code to a done_loading callback
* Rename some variables for clarity and increase scope
* Do not use ascii compare, match unichars
* Update typed characters only when one candidate completion
Do not try to complete when directory is known to be unloadable
b1699af
Fix matching non-ASCII
49fe71f
@jeremypw jeremypw marked this pull request as ready for review June 27, 2022 09:21
@jeremypw jeremypw requested review from a team and mcclurgm June 27, 2022 09:22
@jeremypw jeremypw mentioned this pull request Jun 27, 2022
Closed
@jeremypw jeremypw marked this pull request as draft June 28, 2022 06:53
@jeremypw jeremypw marked this pull request as ready for review July 3, 2022 07:46
@jeremypw jeremypw enabled auto-merge (squash) February 20, 2023 11:24
@jeremypw
Copy link
Collaborator Author

Need discover reason for merged master causing CI failure in all PRs before can merge 😞

@jeremypw jeremypw mentioned this pull request Feb 22, 2023
Merged
6 tasks
@jeremypw jeremypw merged commit 9ec58ab into master Feb 23, 2023
@jeremypw jeremypw deleted the fix-completion-case branch February 23, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok approved these changes

@mcclurgm mcclurgm Awaiting requested review from mcclurgm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pathbar completion should be case sensitive
2 participants
@jeremypw @zeebok