Allow horizontal scrolling when necessary when columns resized in Column View #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcclurgm Are you able to review this? It fixes an issue you raised. |
|
This definitely works. Two thing I notice but I am not sure are important for this PR, two-finger scrolling doesn't work and there is always more scroll area than actual content:
Maybe this is on purpose, I don't know, but I figured I would at least point them out in case this affects either somehow |
zeebok
approved these changes
Mar 7, 2023
|
Removing linked issue as that refers to List View not Column View and is not fixed by this PR. This PR does fix a related (unreported) issue in Column view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add monitoring the size of each column and recalculate total width request when changes (throttled).