Focus FileChooser name entry when saving #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marukesu
reviewed
Feb 2, 2023
|
@danirabbit Your input would be valued regarding on how to balance the needs of touch/mouse users and keyboard only users in relation this PR. |
|
@mcclurgm Requesting a review as you contributed to the linked issue. |
|
@danirabbit After the latest commit, either the entry or the treeview is focused on |
|
@jeremypw I would guess that the intentional of that is to do what you're already doing here on realize, so it's probably a duplicate since I think these methods are only called on activate. I don't think apps are allowed to interfere with the portal while it's running anymore |
Marukesu
reviewed
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2047