Add AppMenu button to headerbar

[jeremypw]

Fixes #2123

• Zoom controls
• • Update label of "normal" button (?)
• • Make zoom insensitive when at max/min zoom
• Undo/Redo controls
• Global boolean options
• • Selection mode for folders
• • Show/hide hidden files
• • Show/hide remote thumbnails
• • Show/hide local thumbnails
• • Sort directories first
• Remove corresponding context menu items (TBD)

Left for possible future PRs

[jeremypw]

@danirabbit A few questions to resolve regarding this PR:

• How to handle labelling of "normal zoom" button. Should it change like in Code and Terminal, in which case how to denote the icon size relative to "normal"? Or is it OK to leave it with a fixed label or icon?
• What is optimum order of the boolean option switches.
• Is there a need/demand to override the system style in Files? Terminal and Code widgets have their own built-in style handling but for Files this is not the case.
• Is it OK to remove the corresponding menuitems from the directory context menu?

Please apply your design expertise to the appearance.

[danirabbit]

@jeremypw this looks awesome!

How to handle labelling of "normal zoom" button. Should it change like in Code and Terminal, in which case how to denote the icon size relative to "normal"? Or is it OK to leave it with a fixed label or icon?

I think using percentages still makes sense here since we have some views with lots of options that saying like "extra small" or "extra large" starts to get meaningless. I think we should still adjust the label to match what is in the view to be consistent here.

What is optimum order of the boolean option switches.

I proposed #2133 with a few suggested changes to organization/structure/appearance

Is there a need/demand to override the system style in Files? Terminal and Code widgets have their own built-in style handling but for Files this is not the case.

I don't think so? The reason that Code/Terminal have these manual overrides is because they're using syntax highlighting schemes where people have pretty strong preferences about using dark/light syntax highlighting separate from the rest of the system. I'm not sure that similar demand exists for other apps

Is it OK to remove the corresponding menuitems from the directory context menu?

Yes! I think we should definitely clean those up so that menu can become simpler

[danirabbit]

Ah something else I noticed is that the zoom actions don't become disabled when they git their min/max values. So for example, the zoom in button is still sensitive even when we're at the max zoom and pressing it has no effect

[jeremypw]

@danirabbit Thanks for the comments! I'll get on with implementing those tomorrow.

[danirabbit]

Oh, actually I'm curious about the "Sort Folders Before Files" option. Is there a reason you wanted to move that here instead of having it with the other sort options in the context menu?

[jeremypw]

Oh, actually I'm curious about the "Sort Folders Before Files" option. Is there a reason you wanted to move that here instead of having it with the other sort options in the context menu?

This is because that is a global option affecting all folders and the file chooser. The other sort options only affect the individual folder you set them on (because in that case they are stored in the file metadata).

[danirabbit]

I think that one still makes sense to have in the context menu with the other sort options, even if we duplicate it in both locations. But just to make sure sorting options are all available at once and someone won't be confused about where to find this when they're changing other sorting options

[jeremypw]

I think that one still makes sense to have in the context menu with the other sort options, even if we duplicate it in both locations. But just to make sure sorting options are all available at once and someone won't be confused about where to find this when they're changing other sorting options

I have no problem with duplicating it in the context menu.

[danirabbit]

It looks like the "local-thumbnails" check is always disabled when files starts. Somewhere along the way action state isn't being set on startup

[jeremypw]

It looks like the "local-thumbnails" check is always disabled when files starts. Somewhere along the way action state isn't being set on startup

Seems that was a pre-existing bug that this PR exposes. Now fixed.

[danirabbit]

Let's go! 🚀

Great work :)