Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BulkRename: Differentiate identical strings for translating #2186

Merged
merged 3 commits into from
May 4, 2023

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented May 4, 2023

Some of the strings used by Bulk Rename are identical to the used ones, which can result in inaccurate translations, this branch marks such strings with "bulk-rename" context.

@lenemter lenemter requested a review from a team May 4, 2023 07:56
@tintou
Copy link
Member

tintou commented May 4, 2023

I would suggest to add /// TRANSLATORS: the context explained to the line before the string definition to allow translators to actually know why it might be different from other strings :)

@tintou tintou merged commit 9b911e7 into master May 4, 2023
@tintou tintou deleted the lenemter/fix-translations branch May 4, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants