Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Rename: Use ModeButton for basename options #2201

Merged
merged 4 commits into from
May 16, 2023

Conversation

jeremypw
Copy link
Collaborator

Partially addresses #2194

@jeremypw jeremypw requested a review from peteruithoven May 12, 2023 17:02
@danirabbit
Copy link
Member

I haven’t built this yet, but ModeButton is removed in Gtk4 so I’m not sure it’s a good idea to introduce a new one

@jeremypw
Copy link
Collaborator Author

@danirabbit Ah - I forgot that. I'll try and do it a Gtk4 compatible way - or do you want to leave it as it is?

@jeremypw jeremypw marked this pull request as draft May 14, 2023 09:45
@jeremypw
Copy link
Collaborator Author

Screenshot from 2023-05-14 12 18 17

@jeremypw jeremypw marked this pull request as ready for review May 14, 2023 11:19
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danirabbit danirabbit enabled auto-merge (squash) May 16, 2023 21:51
@danirabbit danirabbit merged commit 9f670f9 into master May 16, 2023
@danirabbit danirabbit deleted the bulkrename-modeswitch branch May 16, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants