Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectServerDialog: Gtk4 prep #2226

Merged
merged 3 commits into from
Jun 30, 2023
Merged

ConnectServerDialog: Gtk4 prep #2226

merged 3 commits into from
Jun 30, 2023

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jun 30, 2023 •
edited
Loading

Includes changes from #2225

  • Bump copyright header
  • Replace Grids with Boxes
  • Code style
  • Remove unnecessary use of DetailLabel (fields that are never hidden or are hidden by another means)
  • Replace remaining new DetailLabel with new_detail_label
  • Use child instead of add when relevant
  • Replace ButtonBox with Box

@danirabbit danirabbit requested a review from jeremypw June 30, 2023 15:48
jeremypw
jeremypw approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there are parts of the make-compile branch that will compile under both Gtk3 and Gtk4 so it makes sense to merge these first - thanks.

Code looks good, compiles and runs

@jeremypw jeremypw merged commit 7376ae4 into main Jun 30, 2023
@jeremypw jeremypw deleted the danirabbit/connectserverdialog-gtk4prep branch June 30, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @jeremypw