New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ViewSwitcher: fix behavior, don't use observe #2229

Merged

jeremypw merged 1 commit into make-compile from danirabbit/viewswitcher-noobserve

Jul 2, 2023

Member

danirabbit commented Jun 30, 2023

Use group so that we get radio behavior
Granite style class constant
Docs advise against using observe_children when possible because it's expensive


          ViewSwitcher: fix behavior, don't use observe

7190a4f

danirabbit requested a review from jeremypw

June 30, 2023 18:20

danirabbit commented

View reviewed changes

libcore/Widgets/ViewSwitcher.vala

Comment on lines 91 to +92

		}
		child = child.get_next_sibling ();

Member Author

danirabbit Jun 30, 2023

Should we return early here if we activate a child?

jeremypw merged commit 916af09 into make-compile

jeremypw deleted the danirabbit/viewswitcher-noobserve branch

July 2, 2023 09:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet