Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RenamerListBox: Gtk4 prep #2230

Merged
merged 4 commits into from
Jul 2, 2023
Merged

RenamerListBox: Gtk4 prep #2230

merged 4 commits into from
Jul 2, 2023

Conversation

danirabbit
Copy link
Member

RenamerListBox:

  • Can't subclass ListBox so move that into Renamer.vala

RenamerListRow:

  • Update copyright header
  • Only actual construction properties are construct
  • Avoid center box packing
  • Use child property
  • bind newname property
  • explicit margins

@danirabbit danirabbit requested a review from jeremypw June 30, 2023 19:45
@jeremypw jeremypw merged commit aa1f03f into main Jul 2, 2023
@jeremypw jeremypw deleted the danirabbit/renamerlistboxrow branch July 2, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @jeremypw