Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ButtonWithMenu: cleanup, Gtk4 prep #2231

Merged
merged 5 commits into from
Jul 2, 2023
Merged

ButtonWithMenu: cleanup, Gtk4 prep #2231

merged 5 commits into from
Jul 2, 2023

Conversation

danirabbit
Copy link
Member

  • bump copyright header
  • Remove unused properties etc
  • Rewrite using Gtk.Gesture

@danirabbit danirabbit requested a review from jeremypw June 30, 2023 21:14
jeremypw
jeremypw approved these changes Jul 2, 2023
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generates a warning on popup (no current event?) but will need rewriting for Gtk4 anyway.

@jeremypw jeremypw merged commit 8a64562 into main Jul 2, 2023
@jeremypw jeremypw deleted the danirabbit/buttonwithmenu branch July 2, 2023 09:42
@danirabbit
Copy link
Member Author

@jeremypw fixed in the make-compile branch! It now uses a Gtk.PopoverMenu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @jeremypw