Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RenamerDialog: cleanup and Gtk4 prep #2237

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Conversation

danirabbit
Copy link
Member

Screenshot from 2023-07-03 13 57 28
Screenshot from 2023-07-03 13 57 42

  • Bump copyright header
  • Code style
  • Use child property where relevant
  • Create buttons with labels and icons in a Gtk4 friendly way
  • Fix menu appearance for suffix and prefix menubuttons
  • Set revealer transitions so they preserve space correctly
  • Remove keypress handler for REJECT. It doesn't appear that anything listens to this response ID
  • Replace grids with boxes
  • Pack boxes with add where relevant
  • Fix margins, aligns, expands, etc
  • Use MenuButton for mod_button
  • Reduce minimum usable width

@danirabbit danirabbit requested a review from jeremypw July 3, 2023 21:05
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. There are a few minor issues involving some buttons needing to be pressed more than once to work but these are also present in main and outside scope of this PR.

@jeremypw jeremypw merged commit d4b06f1 into main Jul 4, 2023
@jeremypw jeremypw deleted the danirabbit/renamerdialog branch July 4, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants