Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PropertiesWindow: Gtk4 prep #2254

Merged
merged 2 commits into from
Jul 13, 2023
Merged

PropertiesWindow: Gtk4 prep #2254

merged 2 commits into from
Jul 13, 2023

Conversation

danirabbit
Copy link
Member

  • Avoid no_show_all
  • add pixel_size where we can't rely on IconSize in the future
  • explicit hexpand and vexpand
  • Don't use add with grid
  • show dialog with present not show_all
  • Remove a single-use method
  • Code style changes cherried from Make compile #2225

@danirabbit danirabbit requested a review from jeremypw July 12, 2023 19:06
jeremypw
jeremypw approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, no regressions

@jeremypw jeremypw merged commit 60a250e into main Jul 13, 2023
@jeremypw jeremypw deleted the danirabbit/propertieswindow-gtk4prep branch July 13, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @jeremypw