Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window: only construction args in Object #2255

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Conversation

danirabbit
Copy link
Member

Make sure that only things that are passed as construction arguments are present in Object () call

Remove the screen argument. We don't seem to set this anything other than the default. This was added a very long time ago so seems vestigial. According to docs it sounds like this would be used for launching windows on a specific Gdk.Screen, but there's no such functionality so nothing should be lost

This is commented out in #2225

@danirabbit danirabbit requested a review from jeremypw July 12, 2023 22:16
@jeremypw jeremypw merged commit 66f3020 into main Jul 13, 2023
@jeremypw jeremypw deleted the danirabbit/window-args branch July 13, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants