-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of status changes by git plugin when file content changes #2265
Conversation
* Always get status list * Handle Git status INDEX_NEW * Call plugins.update_file_info when needed
* Allow updating status map for single file * Correct error in lookup status * Use same status_options as Code
* So that plugins get updated
* Ignore folders * Handle thrown error
@jeremypw can you resolve conflicts here? |
# Conflicts resolved in: # src/View/AbstractDirectoryView.vala
Linked issue not fixed after merging |
So, it looks like this never solved the entire issue. It only solves the case where the file content changes, so the emblem will change to "modified" when there are uncommitted changes and is removed if the uncommitted changes are reverted. New untracked files will get the appropriate emblem when they appear. However, the emblem does not change automatically when there is a commit made. This is because the file itself does not change - it is the git database that changes. The Code application does detect this because it monitors the Not sure if this partial fix is still worth merging or whether to try for a full fix. |
Closing as not complete fix and no reviews |
Partially fixes #2261
update_file_info
- update git status for single fileupdate_file_info
is called for file changesupdate_file_info
called for file-added events even if file already in cacheupdate_file_info