Do not add transient files to cache or model #2279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeebok
reviewed
Nov 12, 2023
zeebok
approved these changes
Nov 12, 2023
|
Closing as issue seems to have resolved in latest source. |
auto-merge was automatically disabled
February 26, 2024 11:58
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2344
Instead of trying to get fileinfo this PR simply ignores files named ".goutputstream..." and they are not inserted in the Directory file cache nor added to view models.
Not sure if the name filter is optimal or whether other filename forms should also be ignored. Is there a better (and synchronous) way of immediately determining files that should be ignored?