Handle restoring non-existent locations #2303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 30, 2023 17:49
# Conflicts: # src/Application.vala # src/View/Window.vala
jeremypw
added
the
Priority: High
danirabbit
approved these changes
Sep 25, 2023
|
@danirabbit Yes, same here (see #1753 (comment)). Presumably a timing issue only affecting some systems, but the code was flawed anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1753
Because of the timing changes caused by async functions a regression was introduced where two tabs were added when the last tab in a window was removed. This was fixed by removing the unnecessary handler for the
page-detachedsignal. All the necessary work is done in theclose-pagesignal handler.Marking as high priority since the OP reported a crash linked to restoring a location that no longer exists, although I have not been able to reproduce that on my system.