Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursors: Update text and text-vertical cursors #1322

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

wpkelso
Copy link
Member

@wpkelso wpkelso commented Oct 7, 2024

Targets:

  • Updates text and text-vertical to use newer practices for pointer drop-shadow
  • Updates shape language for both pointers

For the initial PR, I have two options ready:

text-cursors-scale

I would appreciate feedback about which option to fully move forward with.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs a bit deeper of a divot on the ends. When viewed at the regular cursor size on LoDPI, the divot isn't really perceptible as compared to the old version

Also, these appear to be a different size than the old cursors. You'll need to update the .in files that go with these to make sure they stay centered, or make sure they are the same size as the old ones

I don't think I've seen a version of this cursor with a crossbar before. The version without is probably better

@wpkelso
Copy link
Member Author

wpkelso commented Oct 7, 2024

I don't think I've seen a version of this cursor with a crossbar before

I guess I could've included it in a 'prior art section', but MacOS/Apple/AppKit uses a crossbar on their iBeam. As far as I can tell, that's the only major platform that uses a crossbar.

I'll push those corrections to the barless version in a bit.

@wpkelso
Copy link
Member Author

wpkelso commented Oct 8, 2024

Current state of things

image

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget you either need to resize these so they're the same size as the old ones were or update the associated .in files with new coordinates

@wpkelso
Copy link
Member Author

wpkelso commented Oct 8, 2024

Dev environment is misbehaving, so I haven't been able to completely test, but the text hotspot should be fixed now. I don't think text-vertical needed any change in its hotspot, but again, I haven't been able to do more than a visual "that looks right."

I'll do more thorough testing if I can get my environment to behave.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

@danirabbit danirabbit merged commit cd491d1 into elementary:main Oct 8, 2024
3 checks passed
@wpkelso wpkelso deleted the cursor-crossbar branch October 8, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants