-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cursors: Update text
and text-vertical
cursors
#1322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it needs a bit deeper of a divot on the ends. When viewed at the regular cursor size on LoDPI, the divot isn't really perceptible as compared to the old version
Also, these appear to be a different size than the old cursors. You'll need to update the .in files that go with these to make sure they stay centered, or make sure they are the same size as the old ones
I don't think I've seen a version of this cursor with a crossbar before. The version without is probably better
I guess I could've included it in a 'prior art section', but MacOS/Apple/AppKit uses a crossbar on their iBeam. As far as I can tell, that's the only major platform that uses a crossbar. I'll push those corrections to the barless version in a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget you either need to resize these so they're the same size as the old ones were or update the associated .in files with new coordinates
Dev environment is misbehaving, so I haven't been able to completely test, but the I'll do more thorough testing if I can get my environment to behave. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice work!
Targets:
text
andtext-vertical
to use newer practices for pointer drop-shadowFor the initial PR, I have two options ready:
I would appreciate feedback about which option to fully move forward with.