Respect user autostart options #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be simpler to load the contents directly in the |
Merged
|
@Marukesu done. |
Marukesu
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently disabling autostart for an app like mail via startup settings gets reverted every time the app is launched again because the app then asks for autostart permission again and the autostart file is entirely overwritten. To disable it one would have to revoke the flatpak permission which currently can't be done graphically without third party tools. Also this wouldn't work for non flatpak applications.
With this PR we check whether an autostart file already exists and if so we check whether it has the hidden key and add it to the new autostart file. We still overwrite it completely to avoid keeping other keys we might not want (I'm not 100% sure whether that's really necessary but it seems the most save way)