Screenshot portal

[davidmhewitt]

Fixes elementary/gala#1807
Fixes elementary/screenshot#140

Implements the Screenshot and Colour Picking portals.

This mostly copies the Screenshot dialog code from the Screenshot app (and ports it to GTK4). But now it runs in the portal process, because the Screenshot app is packaged as a Flatpak itself, so it's not appropriate to have the portal there. There is an additional dialog that prompts the user if they want to share the taken Screenshot with the requesting application.

@danirabbit Could I get you to look at the UX of this and hack on it a bit if you like?

Can use ASHPD to test.

Still to do:

• Make conceal text feature work
• Remember previously selected screenshot options?
• Think about what we do with the actual screenshot app now that this is implemented here.
• Think about where/how these temporary screenshots are stored

[danirabbit]

Yeah I kinda wish there was a way for the app to communicate some kind of intent over the portal so we select a good screenshot option. I'm honestly not sure what are the kinds of use cases for the screenshot portal, otherwise maybe it would be easier to know what a good default is here. For now, I think we can forgo saving options and then see if it comes up in practical use

Re: Duplicating the screenshot app, yeah it would probably be nice to figure out a way to not completely dupe this whole UI 😅. There's a number of issues/discussions around changing the way the save workflow happens in Screenshot so might be low priority until that's more figured out?

I was trying to make the previews/dialog resizable but kept running into weird issues with how Gtk is allocating space for the widget. There's a new content sizing property in newer Gtk, so might just be something to revisit once we have installable Noble builds to hack from.

[Marukesu]

Make the approval dialog look nicer?

Assuming that we won't make another release for OS 7, i don't think we need the approval dialog at all. The portal fronted will check and ask for permission before calling us already.

Think about where/how these temporary screenshots are stored

i would say that portal screenshots should be saved in $XDG_RUNTIME_DIR, it will be sent to the application as read-only and the application will be the one defining the actual final location.

Think about what we do with the actual screenshot app now that this is implemented here.

i think we should remove the flatpak. AFAIK, it don't work outside of pantheon since GNOME closed they screenshot interface. but the app still has they use for "showing a save dialog".

[davidmhewitt]

Just a note here that I looked at where GNOME's portal saves screenshots and it doesn't store them in a temporary location.

It treats them as actual screenshots and saves them to the screenshots folder, which I think makes sense too.

[danirabbit]

I confirmed that the flow in OS 8 is that you get prompted from the request portal, if you disallow screenshot taking apps cannot take a screenshot in non-interactive mode. It doesn't even send the approval dialog. Otherwise the behavior for interactive mode is always allow, which makes sense because by using the screenshot dialog that's an implicit approval

So removed the dialog because it's never called

[danirabbit]

Proposed elementary/icons#1249 to fix missing icon in the request dialog

[danirabbit]

Opened elementary/switchboard-plug-applications#220 to address the setting we need after this is merged

[danirabbit]

@davidmhewitt is there anything still blocking this? Would be great to get this in :)

[davidmhewitt]

I think I'd like to change this from using /tmp to either the user's actual screenshot folder, or at least a user specific temporary folder.

I'm not sure when I'll next be at a PC that's set up enough to make and test those changes though.

[danirabbit]

@davidmhewitt @Marukesu since merging that cache dir branch, any opposition to getting this in?

[davidmhewitt]

No opposition, I think it's good to go. But I haven't looked at this or tested in a long while.

[danirabbit]

I know I touched this code :p but it is working completely as expected afaict