Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better memory and storage info #251

Merged
merged 5 commits into from
Oct 4, 2022
Merged

Better memory and storage info #251

merged 5 commits into from
Oct 4, 2022

Conversation

vjr
Copy link
Member

@vjr vjr commented Oct 1, 2022

Stolen code from GNOME settings repo to use UDev and UDisks libraries to get more accurate memory and storage info.

Memory now shows the physical RAM capacity and storage code collects the total size of all non-removable and non-ejectable disks.

Before: (note the non-physical RAM size using glibtop.mem library and storage size of the root partition only)

about_before2

After: (note the more accurate physical RAM size and storage size of the physical disk)

about_after2

@vjr vjr requested a review from a team October 1, 2022 16:59
@vjr
Copy link
Member Author

vjr commented Oct 1, 2022

I'm not sure how to fix the missing dependency error in the build stages... @elementary/desktop-developers

@vjr
Copy link
Member Author

vjr commented Oct 1, 2022

Here's what it looks like on my laptop - notice the disk size isn't rounded off but still acceptable IMO.

Before:

about_before

After:

about_after

@zeebok
Copy link
Contributor

zeebok commented Oct 4, 2022

I'm not sure how to fix the missing dependency error in the build stages... @elementary/desktop-developers

I believe you need to add those dependencies to the github workflow yml files

src/Views/HardwareView.vala Outdated Show resolved Hide resolved
@vjr vjr requested review from a team and tintou October 4, 2022 06:46
@vjr vjr merged commit fc4cdcf into master Oct 4, 2022
@vjr vjr deleted the better-memory-disk-size branch October 4, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants