DisplaysOverlay: revert check_configuration_changed from #376 #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeebok
approved these changes
May 15, 2024
There was a problem hiding this comment.
This seems like a temporary fix so I'll approve. Looking at this for issues and, maybe I am misunderstanding, if there is only 1 display_widget in total, then it will never be set to connected and result will always be false.
Maybe the real fix is having a check for a length of 1 for display_widgets?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the changes to
check_configuration_changedthat were merged in #376With this new method I can't actually apply settings since it doesn't seem to handle resolution or rotation changes