Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create SensorManager, detect before accel search result #388

Merged
merged 9 commits into from
Aug 14, 2024
Merged

Create SensorManager, detect before accel search result #388

merged 9 commits into from
Aug 14, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jul 13, 2024 •
edited
Loading

Fixes part of #359

Label switch for the screen reader while we're here

@danirabbit danirabbit marked this pull request as ready for review July 13, 2024 22:00
@danirabbit danirabbit requested a review from a team July 13, 2024 22:00
leolost2605
leolost2605 requested changes Aug 14, 2024
View reviewed changes
Copy link
Member

@leolost2605 leolost2605 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe while here can we fix the state mismatch of the switch on launch? I.e. if rotation lock is enabled and we freshly launch settings, the switch is colored but in the "off" position

@danirabbit
Copy link
Member Author

@leolost2605 good catch! Fixed

@danirabbit danirabbit requested a review from leolost2605 August 14, 2024 20:32
leolost2605
leolost2605 approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM very nice :)

@danirabbit danirabbit merged commit ecbc33f into main Aug 14, 2024
3 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/sensormanager branch August 14, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leolost2605 leolost2605 leolost2605 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
A11y
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danirabbit @leolost2605 @zeebok