Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CaldavDialog: use Adw.NavigationView #284

Merged
merged 5 commits into from
Jul 4, 2024

Conversation

danirabbit
Copy link
Member

replaces deprecated Leaflet

@danirabbit danirabbit requested a review from a team June 19, 2024 21:00
@ryonakano
Copy link
Contributor

@danirabbit Could you resolve conflicts and explicit that we now require libadwaita-1 >= 1.4 in README and meson.build?

@danirabbit
Copy link
Member Author

@ryonakano done!

Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, but maybe the same memory leak discussed in #283 happens here too…? 😩

@danirabbit danirabbit requested a review from ryonakano July 3, 2024 16:56
@danirabbit
Copy link
Member Author

@ryonakano should be fixed now!

Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@danirabbit danirabbit merged commit 86fab7b into main Jul 4, 2024
3 of 5 checks passed
@danirabbit danirabbit deleted the danirabbit/caldavdialog-adwnavigationview branch July 4, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants